Welcome to our peer-to-peer forums, where owners help owners. Need help now? Visit eSupport here.

English Community

Linux Operating SystemsOther Linux Discussions
All Forum Topics
Options

389 Posts

03-06-2021

Germany

220 Signins

2355 Page Views

  • Posts: 389
  • Registered: ‎03-06-2021
  • Location: Germany
  • Views: 2355
  • Message 31 of 71

Re:T14s AMD no HDMI audio on Linux

2021-05-26, 21:03 PM

@ schristoforou wrote:

Although I admire your determination in putting more boards to the blacklist (thanks for that), I really think Lenovo should send a list of them so that it can be fed to the kernel as an array, since it is very likely most boards of the X13/T14s/P14s variant will have the same issue.

 

Well, I collect what I can ...

 

I already asked @MarkRHPearson about something like this :)

It's always better some @vedor person send patches upstream,

but I don't have any problem sending patches myself to kernel folks.

Reply
Options

687 Posts

07-22-2019

Canada

477 Signins

5456 Page Views

  • Posts: 687
  • Registered: ‎07-22-2019
  • Location: Canada
  • Views: 5456
  • Message 32 of 71

Re:T14s AMD no HDMI audio on Linux

2021-05-26, 22:10 PM

Sorry - stupid busy meeting day and just catching up on this thread

 

I ran a quick sniff test with my X13 AMD and HDMI audio worked fine, but I am seeing that kernel error. Are we sure they are related?

On my T14 AMD HDMI was completely barfing which I need to look into - something is really messed up there as it definitely used to work.

 

Summary - I need to do a bit more digging first to understand what is going on.

Random thought - I've not updated the BIOS on my X13 yet....anybody seeing the issue with the old BIOS?

 

@osnix - nice on the patch, you should definitely propose it and get credit. I'll happily build and test on my platforms.

 

Mark

 

Reply
Options

389 Posts

03-06-2021

Germany

220 Signins

2355 Page Views

  • Posts: 389
  • Registered: ‎03-06-2021
  • Location: Germany
  • Views: 2355
  • Message 33 of 71

Re:T14s AMD no HDMI audio on Linux

2021-05-26, 22:42 PM

@ MarkRHPearson wrote:

Sorry - stupid busy meeting day and just catching up on this thread

 

I ran a quick sniff test with my X13 AMD and HDMI audio worked fine, but I am seeing that kernel error. Are we sure they are related?

On my T14 AMD HDMI was completely barfing which I need to look into - something is really messed up there as it definitely used to work.

 

Summary - I need to do a bit more digging first to understand what is going on.

Random thought - I' not updated the BIOS on my X13 yet....anybody seeing the issue with the old BIOS?

 

@osnix - nice on the patch, you should definitely propose it and get credit. I' happily build and test on my platforms.

 

Mark

 

 

Yes, the issue is related to that error, please note there are some other errors too ret = -12 and -15 I belive,

not sure about these, but I read all bug reports about and the commit log. This is a Lenovo BIOS bug.

 

Also, there are some more variants of the same machine ( it seems ), maybe some have the bug some not,

and the reason the DMI match changed to board_name in the driver itself. Maybe some have a fix in newer

BIOS, however adding BIOS match in that driver will cause a big mess and solve nothing, since the only

BIOS fix will be 'ACPI: do not announce DMIC ON ACP', and this is what the DMI backlisting does already.

 

 

What is happening here is this:

 

The internal MIC is connected to the HDA codec, easy to figure from dmesg even.

You'll see something like this on these machines:

 

[    2.534668] snd_hda_codec_realtek hdaudioC1D0:      Mic=0x19

 

 

However, while the BIOS still announces 'MIC on ACP bridge support', the driver,

itself continues to run the init code, trying to set up the interrupts, etc and ofc it throws

an error killing the whole sound on ACP...

 

There are already some of these machines on the DMIC blacklist, see

sound/soc/amd/renoir/rn-pci-acp3x.c around L200.

 

Regarding the patch, I don't care about getting credit, what I care about is to get it fast in,

and into stable/LTS. I was hoping for a larger list of affected machines so someone with a 

@lenovo email can submit the larger patch, which is usually taken quickly then :).

 

If you have such a list a Co-Developed by is enough for me on the final patch.

 

Gabriel

 

 

Reply
Options

687 Posts

07-22-2019

Canada

477 Signins

5456 Page Views

  • Posts: 687
  • Registered: ‎07-22-2019
  • Location: Canada
  • Views: 5456
  • Message 34 of 71

Re:T14s AMD no HDMI audio on Linux

2021-05-27, 0:43 AM

OK - got it. Thanks for all the details.

 

Let me have a play with it tomorrow and then as long as I don't find any issues I'll push it.

 

I'm honestly a bit bugged about this - this is basic functionality that should be caught during our certification. Not sure why this is showing up now; is it a basic miss (which really sucks) or something we broke (which still sucks - but a little less)

 

I'll raise this with the firmware team - but that's a much slower process.

I think I have your email address, but if not pm me so I can add you to the patch

 

Mark

 

Reply
Options

389 Posts

03-06-2021

Germany

220 Signins

2355 Page Views

  • Posts: 389
  • Registered: ‎03-06-2021
  • Location: Germany
  • Views: 2355
  • Message 35 of 71

Re:T14s AMD no HDMI audio on Linux

2021-05-27, 1:12 AM

@ MarkRHPearson wrote:

OK - got it. Thanks for all the details.

 

Let me have a play with it tomorrow and then as long as I don' find any issues I' push it.

 

I' honestly a bit bugged about this - this is basic functionality that should be caught during our certification. Not sure why this is showing up now; is it a basic miss (which really sucks) or something we broke (which still sucks - but a little less)

 

I' raise this with the firmware team - but that' a much slower process.

I think I have your email address, but if not pm me so I can add you to the patch

 

Mark

 

 

My email is in the second git patch.

 

https://crazy.dev.frugalware.org/Lenovo/0001-ASoC-AMD-Renoir-add-DMI-entry-for-Lenovo-ThinkPad-P1.patch

 

I got this issue from the beginning but figured the kernel cmd fixed it

and to be honest I forgot to look what caused it.

 

While I did some testing regarding this new TSC bug and the S3/S0ix problems

I removed all kernel cmd workarounds and forgot to put it back.

It's why I could reproduce that now and decided to find out what causes it :).

 

Also, don't worry, noone can catch all bugs.

 

Gabriel

 

 

 

 

Reply
Options

45 Posts

02-28-2021

Isle of Man

59 Signins

420 Page Views

  • Posts: 45
  • Registered: ‎02-28-2021
  • Location: Isle of Man
  • Views: 420
  • Message 36 of 71

Re:T14s AMD no HDMI audio on Linux

2021-05-27, 8:22 AM

I have the exact same message on dmesg. My board is 20UDCTO1WW (Lenovo ThinkPad T14 AMD Gen 1).

 

I must say I didn't experience any issue with sound on Arch Linux + KDE through HDMI, except that internal mic volume is too low. Maybe it could be related.

Reply
Options

389 Posts

03-06-2021

Germany

220 Signins

2355 Page Views

  • Posts: 389
  • Registered: ‎03-06-2021
  • Location: Germany
  • Views: 2355
  • Message 37 of 71

Re:T14s AMD no HDMI audio on Linux

2021-05-27, 9:08 AM

Another T14 , 20UDS0DK00 from there:

 

https://forums.lenovo.com/t5/Other-Linux-Discussions/AMD-T14-kernel-error-about-acp-pdm-mach/m-p/5066593?page=1#5339780

Reply
Options

389 Posts

03-06-2021

Germany

220 Signins

2355 Page Views

  • Posts: 389
  • Registered: ‎03-06-2021
  • Location: Germany
  • Views: 2355
  • Message 38 of 71

Re:T14s AMD no HDMI audio on Linux

2021-05-27, 9:13 AM

@ theowatt wrote:

I have the exact same message on dmesg. My board is 20UDCTO1WW (Lenovo ThinkPad T14 AMD Gen 1).

 

I must say I didn' experience any issue with sound on Arch Linux + KDE through HDMI, except that internal mic volume is too low. Maybe it could be related.

 

There are so many variants of the same machine, only Lenovo can ( maybe ) find out which 

models may work, which is completely broken, etc.

 

When your MIC is connected to the internal HDA codec, that's a bug on your box too.

Reply
Options

51 Posts

08-19-2020

Germany

87 Signins

555 Page Views

  • Posts: 51
  • Registered: ‎08-19-2020
  • Location: Germany
  • Views: 555
  • Message 39 of 71

Re:T14s AMD no HDMI audio on Linux

2021-05-27, 11:09 AM

Does it makes sense to push blacklist patch to kernel? 

 

Fix in BIOS would probably take less time, then the whole process of pushing patch to upstream kernel, releasing new kernel version and waiting for its adoption by different distros.

 

And blacklist is still not a fix, but a workaround.

Reply
Options

389 Posts

03-06-2021

Germany

220 Signins

2355 Page Views

  • Posts: 389
  • Registered: ‎03-06-2021
  • Location: Germany
  • Views: 2355
  • Message 40 of 71

Re:T14s AMD no HDMI audio on Linux

2021-05-27, 11:22 AM

@ Iluha wrote:

Does it makes sense to push blacklist patch to kernel? 

 

Fix in BIOS would probably take less time, then the whole process of pushing patch to upstream kernel, releasing new kernel version and waiting for its adoption by different distros.

 

And blacklist is still not a fix, but a workaround.

 

Yes, it does.

 

The BIOS fix will do the same as the blacklist, so for those machines, it doesn't matter which way they get the fix.

Also, a BIOS fix is fine as long people updates their BIOS, so having the fix in both kernel & BIOS is a good thing.

And one more thing, there are some Yoga/IdeaPad machines affected also, those won't probably see a BIOS fix ever.

 

Gabriel

Reply
Forum Home

Community Guidelines

Please review our Guidelines before posting.

Learn More

Check out current deals!

Go Shop
X

Save

X

Delete

X

No, I don’t want to share ideas Yes, I agree to these terms